Hi Kalle, On Thu, 23 Aug 2018 16:37:45 +0530 Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> writes: > > >> >>> We need help to review and identify if there are any pending > >> >>> items for wilc1000 driver, so we can address those issues and > >> >>> make it ready to move to the wireless subsystem. > >> >> > >> >> I think the best way to get that forward is to submit a patch > >> >> (or patchset) to linux-wireless, that's the easiest for > >> >> reviewers. > >> > > >> > For brcm80211 drivers we used a single patch introducing it under > >> > the wireless drivers folder. Because it was quite a sizable > >> > patch we parked it on the wireless wiki page. Had a few > >> > iterations doing it like that. > >> > >> Another option is to split it so that there's one patch per file, > >> should be even pretty easy to automate that. It's just so much > >> easier to comment on a patch submitted by email compared to the > >> reviewer manually copying code and then commenting it, yuck. > >> > > > > Sure. I will prepare a patch per file send for review as its easy to > > review. > > > > As Greg suggested, I will wait for the merge window to close and > > after completing pending patches to staging, I will start the > > review. > > > > For my understanding, the patches for review will be based on > > wireless-testing branch. > > In this case I think wireless-drivers-next is the safest choise, > wireless-testing also has other trees which might cause conflicts etc. I have submitted a patch series for wilc1000 driver, single file per patch and its based on wireless-drivers-next. I hope its done correctly, please provide inputs so we can address and make this driver ready for mainline. Regards, Ajay
