On 2018-09-19 07:50, Toke Høiland-Jørgensen wrote:
Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
Toke Høiland-Jørgensen <toke@xxxxxxx> writes:
Unfortunately ath10k is not reporting last_tx_rate in tx_status().
So
I also applied this "ath10k: report tx rate using
ieee80211_tx_status"
change.
Yeah, that and the patch that computes the last used rate will
probably
be necessary; but they can be pretty much applied as-is, right?
Unfortunately not. I think the plan is now to follow Johannes'
proposal:
"I'd recommend against doing this and disentangling the necessary
code in mac80211, e.g. with ieee80211_tx_status_ext() or adding
similar APIs."
https://patchwork.kernel.org/patch/10353959/
Ahh, right... *that* patch :)
Was thinking on this one with the "as-is" comment:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/588189
It is useful only when the driver calls tx_status_noskb(). It was
recommended not to
call tx_status() and tx_status_noskb() APIs from same driver. Hence Anil
was trying
to piggyback tx rate report by tx_status itself.
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1e034d84bd444fd29b7f902c5e033a8c737a58b2%5E%21/
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2a8da427fc9dfb527516e7ac395b1e6af73bff84%5E%21/
-Rajkumar
