mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm not sure you can call it a regression, but adding a new driver with a known bug that breaks an entire use case (monitor mode) seems silly when a small and tested fix is available. Pretty please. Thanks, Zero On Tue, Sep 18, 2018 at 8:43 AM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > > > On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote: > >> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote: > >> > According to vendor sdk, vco calibration has to be executed > >> > for each channel configuration whereas mcu calibration has to be > >> > performed during channel scanning. This patch fixes the mt76x0 > >> > monitor mode issue since in that configuration vco calibration > >> > was never executed > >> > > >> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files") > >> > Tested-by: Sid Hayn <sidhayn@xxxxxxxxx> > >> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> > >> > >> Acked-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > > > For the record this is 4.19 material. > > I really want to minimise conflicts and because of so many mt76 patches > conflicts are likely to happen, so I'm keeping the bar high for mt76 > patches going 4.19. Is this a regression from 4.18? If not, I think this > should go to -next and cc stable. And besides, monitor mode isn't that > critical anyway. > > -- > Kalle Valo