On Tue, 2008-07-15 at 11:29 +0300, Tomas Winkler wrote: > We are providing power save user interface reach enough to specify all > the above requirements. > I think you are both misinterpreting listen interval meaning. > Listen interval merely says to AP for how many beacons save direct > packets for this STA. It doesn't mean > it's can be shorter and it does say it's won't be longer. Right, but it does make sense to advertise what we're using, and this patch just adds a strict "driver tells mac80211 what it's using" flow. That's mostly what I'm objecting to. If you were calling the variable "max_listen_interval" and having mac80211 send it back to the driver in the BSS config as bssconf->listen_interval, and, for now, simply use the max, I wouldn't have a problem with it. > It's > doesn't affect power save dynamics it's just sets upper limit. > This value for iwlwifi hw is derived from maximal supported beacon > interval and size of the internal HW timers. > This value is hard coded in the driver. Shouldn't it depend on the beacon interval then? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
