On 2018-09-03 15:48, Johannes Berg wrote:
On Fri, 2018-08-31 at 15:29 +0300, Kalle Valo wrote:
Too me this feels like a bad idea but I'm not familiar enough with
mac80211 to really comment on this. What kind of implications does
this
have for Mesh or ATF, for example? Adding Johannes and Toke to hear
about their opinion about this.
The biggest implication is probably radiotap. Beyond that, it's using
this to report the "last rate" to nl80211, but that's not all super
useful anyway.
The retry count is also affected, and since you report "somewhat
liberally" that would lead to erroneous statistics.
I'd recommend against doing this and disentangling the necessary code
in
mac80211, e.g. with ieee80211_tx_status_ext() or adding similar APIs.
johannes
Thanks for the review.
Is this okay to implement a new API to update the tx rate alone?
Code snippet:
/**
* ieee80211_tx_status_rate_upd - transmit rate update callback
*
* This function can be used in drivers that does not have provision
* in updating the tx rate in data path.
*
* @hw: the hardware the frame was transmitted by
* @status: tx status information
* @pubsta: the station to update the tx rate for.
*/
void ieee80211_tx_status_rate_upd(struct ieee80211_hw *hw,
struct ieee80211_sta *pubsta,
struct ieee80211_tx_info *info);
Source:
void ieee80211_tx_status_rate_upd(struct ieee80211_hw *hw,
struct ieee80211_sta *pubsta,
struct ieee80211_tx_info *info)
{
struct ieee80211_local *local = hw_to_local(hw);
struct ieee80211_supported_band *sband;
int retry_count;
int rates_idx;
struct ieee80211_tx_status status = {
.skb = NULL,
.info = info,
};
ieee80211_tx_get_rates(hw, info, &retry_count);
sband = hw->wiphy->bands[info->band];
if (pubsta) {
struct sta_info *sta;
sta = container_of(pubsta, struct sta_info, sta);
status.sta = &sta->sta;
rate_control_tx_status(local, sband, &status);
if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL) &&
(rates_idx != -1))
sta->tx_stats.last_rate = info->status.rates[rates_idx];
}
}
EXPORT_SYMBOL(ieee80211_tx_status_rate_upd);
Thanks
Anil.
