Search Linux Wireless

Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-08-31 at 15:29 +0300, Kalle Valo wrote:

> Too me this feels like a bad idea but I'm not familiar enough with
> mac80211 to really comment on this. What kind of implications does this
> have for Mesh or ATF, for example? Adding Johannes and Toke to hear
> about their opinion about this.

The biggest implication is probably radiotap. Beyond that, it's using
this to report the "last rate" to nl80211, but that's not all super
useful anyway.

The retry count is also affected, and since you report "somewhat
liberally" that would lead to erroneous statistics.

I'd recommend against doing this and disentangling the necessary code in
mac80211, e.g. with ieee80211_tx_status_ext() or adding similar APIs.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux