Wen Gong <wgong@xxxxxxxxxxxxxxxx> writes: >> > +enum wmi_nlo_cipher_algorithm { >> > + WMI_NLO_CIPHER_ALGO_NONE = 0x00, >> > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01, >> > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02, >> > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04, >> > + WMI_NLO_CIPHER_ALGO_WEP104 = 0x05, >> > + WMI_NLO_CIPHER_ALGO_BIP = 0x06, >> > + WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP = 0x100, >> > + WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP = 0x100, >> >> Two defines with the same value 0x100, is this really correct? > > Yes, it is an interface between host driver /firmware. Yeah, I know it's an interface between the host driver and the firmware but it does not make any sense and is just confusing. Either of them should be dropped. -- Kalle Valo