> -----Original Message-----
> From: ath10k <ath10k-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of Kalle Valo
> Sent: Tuesday, September 4, 2018 5:15 PM
> To: Wen Gong <wgong@xxxxxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; ath10k@xxxxxxxxxxxxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN
> feature
>
> Wen Gong <wgong@xxxxxxxxxxxxxx> writes:
>
> > For WoWLAN support, it expect to support wake up based on discovery of
> [...]
>
> > + channel_list = (u32 *)ptr;
> > + for (i = 0; i < cmd->num_of_channels; i++)
> > + channel_list[i] = pno->a_networks[0].channels[i];
>
> channel_list does not look endian safe to me, I'll change this to use __le32.
Yes, __le32 is more safe.
> > +enum wmi_nlo_cipher_algorithm {
> > + WMI_NLO_CIPHER_ALGO_NONE = 0x00,
> > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01,
> > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02,
> > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04,
> > + WMI_NLO_CIPHER_ALGO_WEP104 = 0x05,
> > + WMI_NLO_CIPHER_ALGO_BIP = 0x06,
> > + WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP = 0x100,
> > + WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP = 0x100,
>
> Two defines with the same value 0x100, is this really correct?
Yes, it is an interface between host driver /firmware.
> --
> Kalle Valo
>
> _______________________________________________
> ath10k mailing list
> ath10k@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/ath10k
