Search Linux Wireless

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Thu, 2 Aug 2018 09:34:54 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote:
> > Cleanup patch to fix below checkpatch reported issue:
> > -#define ISWILC1000(id)			((id & 0xfffff000)
> > == 0x100000 ? 1 : 0) +#define ISWILC1000(id)		(((id)
> > & 0xfffff000) == 0x100000 ? 1 : 0)
> 
> Even better, make this an inline function that returns a boolean to
> avoid any potental problems.
> 

Sure, I will make these changes and submit new patch.

Regards
Ajay



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux