On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > Cleanup patch to fix below checkpatch reported issue: > > Macro argument 'id' may be better as '(id)' to avoid precedence issues > > Also updated the TODO file to remove the below item > 'rework comments and function headers(also coding style)' > > Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> > --- > drivers/staging/wilc1000/TODO | 1 - > drivers/staging/wilc1000/wilc_wlan.h | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO > index 6fd3a4c..862e9ea 100644 > --- a/drivers/staging/wilc1000/TODO > +++ b/drivers/staging/wilc1000/TODO > @@ -1,4 +1,3 @@ > TODO: > -- rework comments and function headers(also coding style) > - support soft-ap and p2p mode > - support resume/suspend function > diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h > index 696cf1f..cd1ff85 100644 > --- a/drivers/staging/wilc1000/wilc_wlan.h > +++ b/drivers/staging/wilc1000/wilc_wlan.h > @@ -4,7 +4,7 @@ > > #include <linux/types.h> > > -#define ISWILC1000(id) ((id & 0xfffff000) == 0x100000 ? 1 : 0) > +#define ISWILC1000(id) (((id) & 0xfffff000) == 0x100000 ? 1 : 0) Even better, make this an inline function that returns a boolean to avoid any potental problems. thanks, greg k-h
