Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> writes: >> > This patch implements core WoWLAN support in qtnfmac driver, including >> > processing of WoWLAN features reported by firmware and implementation >> > of cfg80211 suspend/resume/wakeup callbacks. Currently the following >> > WoWLAN triggers are supported: disconnect, magic packet, >> > custom pattern packet. >> > >> > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> >> >> Doesn't apply anymore as I dropped patch 5 >> >> fatal: sha1 information is lacking or useless >> (drivers/net/wireless/quantenna/qtnfmac/cfg80211.c). >> error: could not build fake ancestor >> Applying: qtnfmac: implement basic WoWLAN support >> Patch failed at 0001 qtnfmac: implement basic WoWLAN support >> The copy of the patch that failed is found in: .git/rebase-apply/patch >> >> Patch set to Changes Requested. > > Thanks for review. I will rebase the remaining patches on top of your > up-to-date tree and resubmit. > > As for the patch with vendor specific commands, I will split it into > a separate discussion and make another attempt to convince you, adding > proper description. Thanks, please do that. And always try to submit controversial patches separately, not within a bigger patchset. > IIRC there is no generic functionality suitable for this particular > usecase. The bigger problem here is that what should we do with the vendor commands, the current way of things (=some low level hardware related commands are accepted) does not work as it takes too much of my time. People always try to take the easy way out so they provide minimal documentation for vendors commands and don't even considering having a generic nl80211 interface, which needs from me quite significant effort to make the decision if the vendor interface is acceptable or not. Personally I would just reject all vendor commands but on the otherhand I somewhat understand why in some cases they might be good. Dunno. -- Kalle Valo
