On Thu, Jul 10, 2008 at 1:24 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2008-07-10 at 01:17 +0300, Tomas Winkler wrote: > >> This is not a bug in mac. >> The sequence number can be committed only if the packet is not dropped >> somewhere in the driver. See lower in the function.. There are plenty >> of places on the TX path when packet can be dropped this it's last >> station. There is no reason to pushing this into mac > > I don't see it that way. In fact, in the code I'm looking at, there is > nothing that drops the frame before committing the sequence number > change after assigning it. > > And all the cases where it drops the frame _before_ the piece of code I > quoted don't actually matter, the first bunch of those are bugs and the > not associated one is strange but most likely doesn't matter either (if > we're not associated sequence numbers don't matter), and the > "destination STA entry not found" one doesn't matter either since that > means there's some disconnect/bug between iwlwifi and mac80211 since > they should synchronise via sta_notify(). Unfortunately sta_notify still does nothing in iwlwifi, need some more work on this. I've eliminated most dropping places over the time if you look in the history it wasn't like that before and not all of the parts of the code develops in the same speed. Anyhow it doesn't matter for the packet that was dropped but it matter for the packet that will come. I think that advancing sequence number should be low as possible. I'm not sure about other drivers' drop points. > Which particular item do you see as problematic? Most problem at the time was found a good place for it in the mac80211. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
