From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
The vdev-start-response message should cause the
completion to fire, even in the error case. Otherwise,
the user still gets no useful information and everything
is blocked until the timeout period.
Add some warning text to print out the invalid status
code to aid debugging.
Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
---
drivers/net/wireless/ath/ath10k/wmi.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index a60de71..ec4cd1e 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3443,12 +3443,18 @@ void ath10k_wmi_event_vdev_start_resp(struct ath10k *ar, struct sk_buff *skb)
ret = ath10k_wmi_pull_vdev_start(ar, skb, &arg);
if (ret) {
ath10k_warn(ar, "failed to parse vdev start event: %d\n", ret);
- return;
+ goto out;
}
- if (WARN_ON(__le32_to_cpu(arg.status)))
- return;
+ if (WARN_ON_ONCE(__le32_to_cpu(arg.status))) {
+ ath10k_warn(ar, "vdev-start-response reports status error: %d\n",
+ __le32_to_cpu(arg.status));
+ /* Setup is done one way or another though, so we should still
+ * do the completion, so don't return here.
+ */
+ }
+out:
complete(&ar->vdev_setup_done);
}
--
2.4.11
