Govind Singh <govinds@xxxxxxxxxxxxxx> writes:
> From: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
>
> Add support to create the boardname for non-bmi targets
> like WCN3990, which uses qmi for bdf download. This
> boardname is used to parse the board data from board-2.bin.
>
> Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
> Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 14 ++++++++++++++
> drivers/net/wireless/ath/ath10k/core.h | 2 ++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 4cf54a7ef09a..8a592019cc4d 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -1429,6 +1429,20 @@ static int ath10k_core_create_board_name(struct ath10k *ar, char *name,
> goto out;
> }
>
> + if (ar->id.qmi_ids_valid) {
> + if (ar->id.qmi_board_id > 0x99)
> + scnprintf(name, name_len,
> + "bus=%s,qmi-board-id=%03x",
> + ath10k_bus_str(ar->hif.bus),
> + ar->id.qmi_board_id);
> + else
> + scnprintf(name, name_len,
> + "bus=%s,qmi-board-id=b%02x",
> + ath10k_bus_str(ar->hif.bus),
> + ar->id.qmi_board_id);
> + goto out;
> + }
Why not just use %d? What benefit would hexadecimal format bring?
And why %02 and %03? I don't see the need for that.
--
Kalle Valo
