Search Linux Wireless

Re: [ath5k-devel] [PATCH] ath5k: convert LED code to use mac80211 triggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bob Copeland wrote:
On Tue, Jul 8, 2008 at 7:08 PM, Helge Deller <deller@xxxxxx> wrote:
I tested it against Linus' head version (it applied with minor
modifications) on my HP NC6000 laptop with this built-in Atheros card:
[...]
Basically it works, but I think the sc->led_on in:
+     sc->led_on = 0;  /* active low */
needs to be:
+     sc->led_on = 1;  /* active high */
for the AR5212 in the HP laptop.

Thanks for the test!

See also the changes to if_ath_pci.c in:
 http://madwifi.org/attachment/ticket/1018/led.patch
and
 http://madwifi.org/ticket/1018
for an old discussion about madwifi for LEDs in the HP box.

So current madwifi doesn't have this change unless I missed something?

Yes, the patch has not been applied yet.

 It appears to use active-low leds in the current version regardless
of the vendor.

Yes.

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux