Bob Copeland wrote:
> This change cleans up the ath5k LED code and converts it to use
> the standard LED device class along with the rx/tx LED triggers
> provided by mac80211.
...
> I tested this with printk but I don't have the IBM 5212/5211/Compaq
> hardware to fully test. If anyone can give it a spin or has comments
> please let me know.
I tested it against Linus' head version (it applied with minor
modifications) on my HP NC6000 laptop with this built-in Atheros card:
02:04.0 Ethernet controller: Atheros Communications, Inc. AR5212 802.11abg
NIC (rev 01)
Subsystem: Compaq Computer Corporation Unknown device 00e5
Basically it works, but I think the sc->led_on in:
> +static int
> +ath5k_init_leds(struct ath5k_softc *sc)
> +{
> + int ret = 0;
> + struct ieee80211_hw *hw = sc->hw;
> + struct pci_dev *pdev = sc->pdev;
> + char name[ATH5K_LED_MAX_NAME_LEN + 1];
> +
> + sc->led_on = 0; /* active low */
needs to be:
> + sc->led_on = 1; /* active high */
for the AR5212 in the HP laptop.
See also the changes to if_ath_pci.c in:
http://madwifi.org/attachment/ticket/1018/led.patch
and
http://madwifi.org/ticket/1018
for an old discussion about madwifi for LEDs in the HP box.
Without this change the LED stays on after a "rmmod ath5k" as well.
Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
