On 2018-06-20 11:51, Ben Greear wrote:
On 06/20/2018 11:48 AM, Rajkumar Manoharan wrote:
On 2018-06-20 10:42, Ben Greear wrote:
On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote:
[...]
This case should not be dealt in ath10k, rather we should make sure
packets does not reach the driver during hardware restart after the
firmware crash.
Can you please try the RFC patch and see if it fixes the issue? I am
working on the patch and probably send it out after doing some
testing and cleanup.
https://patchwork.kernel.org/patch/10411967/
I did see your patch, but I was not sure it would make it upstream.
I think either way my patch might be useful in case bugs creep back
in.
ar->state check can not be in hot path as it is protected by mutex
lock.
If the tx logic is ever called while state is changing, that would seem
to be a bug as well?
Thats true. The assumption is that packets should not be given to driver
after ieee80211_stop_queues is called. Isn't it? Manikanta is trying to
fix
some cases where packets are still continued to sent even after queue
stop.
Worth trying that.
-Rajkumar
