On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
This is against the 4.16 kernel, likely applies to later kernels
as well. Firmware is beta ath10k-ct firmware for 9984 NIC. The
patch is not firmware or chipset specific.
When firmware crashes, packets can still be sent from the
mac80211 stack, and that can cause crashes in the ath10k
tx path.
Yes, this is what I had observed and explained in the RFC patch which I have sent some time back. In my case the device never comes up and the entire system
crashes; I hope you have observed the same behavior.
After adding this patch, I saw cases where the tx path was
called in state ATH10K_STATE_RESTARTED.
I have not tested the tx_64 path, but assume it has similar
issues, so same patch was added to it.
This case should not be dealt in ath10k, rather we should make sure packets does not reach the driver during hardware restart after the firmware crash.
Can you please try the RFC patch and see if it fixes the issue? I am working on the patch and probably send it out after doing some testing and cleanup.
https://patchwork.kernel.org/patch/10411967/
I did see your patch, but I was not sure it would make it upstream.
I think either way my patch might be useful in case bugs creep back in.
And yes, I did see full system crash in this case.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
