On Wed, 2018-06-20 at 09:54 +0200, Arend van Spriel wrote: > On 6/20/2018 9:53 AM, Johannes Berg wrote: > > On Wed, 2018-06-20 at 09:51 +0200, Arend van Spriel wrote: > > > On 6/19/2018 5:39 PM, Denis Kenzior wrote: > > > > On pre-emption enabled kernels the following oops was being seen due > > > > to missing local_bh_disable/local_bh_enable calls. mac80211 assumes > > > > that pre-emption is disabled in the data path. > > > > > > No sure if "assumes" is the right term here. It seems like it is > > > required and there is probably a good reason for that. Would be nice to > > > know what that reason is. > > > > It's using per-CPU data. > > Hence the smp_processor_id() call which Denis mentioned in the bug report? Yeah, I think that's an implementation detail thereof. johannes
