Pkshih <pkshih@xxxxxxxxxxx> writes: >> And I even read all 19 commit logs and there was no mention of why this >> is needed either. I cannot just blindly apply patches without knowing >> what they do. >> > > This new module halmac is an abstract layer for Realtek WiFi MAC to provide > common interfaces to access WiFi MAC and register set. If driver (I use 'driver' > in this mail indicates part of rtlwifi excluded from this module.) uses the API, > it's not necessary to control related register directly. If API isn't implemented, > driver can use the registers defined by halmac to manipulate MAC function. > > The registers reside in driver causes error frequently, because MAC register > is maintained by Realtek's MAC team so they create this module to avoid mistakes. > Another benefit is to make it possible to become a thin driver, because many > common functions are provided, so duplicate code will be reduced. > > Currently, this module is aim to rtl8822be, and it will extend to support > more chips so hierarchical directory is adopted. It looks like > rtlwifi/halmac/halmac_88xx > rtlwifi/halmac/halmac_88xx/halmac_8822b > rtlwifi/halmac/halmac_88xx/halmac_8821c (future chip) IMHO the directory structure contains redundant information, it's enough to have halmac only once in the path. So I would instead use this kind of naming: rtlwifi/halmac/88xx/8822b -- Kalle Valo
