Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > >> On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote: >>> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >>> >>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote: >>> > > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >>> > > >>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote: >>> > > > > >>> > > > > I guess these warnings come because Toke's patch increased size of >>> > > > > struct cfg80211_tid_stats (which is included in struct station_info) and >>> > > > > both wil6210 and qtnfmac allocate a struct station_info from stack? >>> > > > >>> > > > Yes. >>> > > > >>> > > > > Can >>> > > > > someone send a fix for the drivers? >>> > > > >>> > > > I guess Toke/I should do that through my tree. >>> > > >>> > > IMHO the fix could go through my tree as well, less risk of conflicts in >>> > > drivers. AFAICS the fix (allocating station_info dynamically?) would not >>> > > depend on Toke's patch and could be applied separately. >>> > >>> > That's true, if you prefer that it's fine with me. >>> >>> I'll send a patch. >>> >>> What's the right tag to put in the commit for this? >>> Fixes-but-is-independent-from: ? ;) >> >> Heh. You can still put Fixes: I think. > > Yeah, I think so too. Cool. My "git grep 'struct station_info sinfo'" also shows up a driver in staging; that should be fixed as well, right? In the same commit? -Toke
