Search Linux Wireless

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:

> On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>> 
>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> > > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>> > > 
>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > > > > 
>> > > > > I guess these warnings come because Toke's patch increased size of
>> > > > > struct cfg80211_tid_stats (which is included in struct station_info) and
>> > > > > both wil6210 and qtnfmac allocate a struct station_info from stack? 
>> > > > 
>> > > > Yes.
>> > > > 
>> > > > > Can
>> > > > > someone send a fix for the drivers?
>> > > > 
>> > > > I guess Toke/I should do that through my tree.
>> > > 
>> > > IMHO the fix could go through my tree as well, less risk of conflicts in
>> > > drivers. AFAICS the fix (allocating station_info dynamically?) would not
>> > > depend on Toke's patch and could be applied separately.
>> > 
>> > That's true, if you prefer that it's fine with me.
>> 
>> I'll send a patch.
>> 
>> What's the right tag to put in the commit for this?
>> Fixes-but-is-independent-from: ? ;)
>
> Heh. You can still put Fixes: I think.

Yeah, I think so too.

-- 
Kalle Valo




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux