On Fri, Apr 27, 2018 at 05:44:16AM +0000, Pkshih wrote: > > The registers reside in driver causes error frequently, because MAC register > is maintained by Realtek's MAC team so they create this module to avoid mistakes. > Another benefit is to make it possible to become a thin driver, because many > common functions are provided, so duplicate code will be reduced. How is it possible to create a thin driver by adding lots more code and layers of indirection ??? and writing it in a way that it won't compile without the code for every type of bus interface even though most modules only use one ? It's a horrible pile of garbage slapped together by an inexperienced programmer. Its a major deterrent for anyone looking at working on one of the latest realtek drivers.
