Hi Kalle, thank you for reviewing our patch. I am ok with applying this patch without "ANDROID:" prefix. Do you want me to send an updated patch? Regards, Roman. On Wed, Apr 11, 2018 at 9:23 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > rkir@xxxxxxxxxx writes: > > From: Bjoern Johansson <bjoernj@xxxxxxxxxx> > > > > Indicate support for power state changes and handle them by calling an > > empty function. > > The important part is "ieee80211_hw_set(hw, SUPPORTS_PS);" at the > > bottom of the diff. Without this upper layers in the kernel will return an > > error code when trying to set the power state because the driver doesn't > > indicate power state support. This in turn causes VTS > > (Android Vendor Test Suite) failures because the WiFi HAL can't enable > > power saving mode. The remaining code is just there to deal with the > > incoming state change request. > > > > Signed-off-by: Bjoern Johansson <bjoernj@xxxxxxxxxx> > > Signed-off-by: Lingfeng Yang <lfy@xxxxxxxxxx> > > Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx> > Why the odd "ANDROID:" prefix? > -- > Kalle Valo