On Thu, 2008-07-03 at 10:31 +0200, Michael Buesch wrote: > On Thursday 03 July 2008 08:35:23 Kalle Valo wrote: > > Michael Buesch <mb@xxxxxxxxx> writes: > > > > > +drop_packet: > > > + /* We can not transmit this packet. Drop it. */ > > > + dev_kfree_skb_any(skb); > > > return NETDEV_TX_OK; > > > > So no need to call ieee80211_tx_status() in this case? I'm just > > curious about this, nothing else. > > I don't think we must call tx_status for dropped or lost packets. That's a bit of a corner case really. If you call tx-status then the rate control algorithm will adjust to something that hasn't happened, and if you don't then the packet won't be on the monitor interface. In practice, it doesn't really matter because so far this only happens during resume and that'll hopefully get fixed. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
