On Mar 21, Arnd Bergmann wrote: > On Wed, Mar 21, 2018 at 6:45 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Fri, 2018-03-16 at 15:45 +0100, Lorenzo Bianconi wrote: > >> --- a/drivers/net/wireless/mediatek/mt76/Kconfig > >> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > >> @@ -1,5 +1,8 @@ > >> config MT76_CORE > >> tristate > >> + select MAC80211_LEDS > > > > Should drivers really mess with mac80211's configuration that way? I > > believe this is a user-visible config, no? > > We have a couple of drivers using 'select LEDS_CLASS' and others > doing 'depends on LEDS_CLASS'. I think the latter is what we should > have here for all those drivers. > > MAC80211_LEDS looks like it's designed to be optional, so nothing > should select or depend on that. > > Arnd Reviewing the current code we do not actually need MAC80211_LEDS, so I agree to remove it from Kconfig and let userspace selects the option. I would use select for LEDS_CLASS. If you agree I can send a v2 otherwise I fine to apply Arnd's patch. Felix what do you think? Regards, Lorenzo
