Hi Johannes,
On 03/21/2018 10:13 AM, Johannes Berg wrote:
TODO:
That was well-hidden :)
Sorry. I assumed people read the change log :)
- It is unclear to me how AP_VLAN and AP interfaces should synchronize on
conn_owner_nlportid. This is required for tx_control_port to work.
I'm not really sure what you mean? Technically I guess an AP_VLAN could
have a different owner from an AP, but if the AP goes down all the
AP_VLANs go down with it already anyway.
So the issue is that when mac80211 calls cfg80211_rx_control_port and
subsequently __nl80211_rx_control_port, we grab the nlportid from the
wdev. So if that isn't synchronized, then AP_VLAN devices won't be
sending the EAPoL frames to the right place.
- JOIN_IBSS & JOIN_MESH don't seem to support control_port_ethertype or
control_port_no_encrypt. Should struct cfg80211_crypto_settings parsed inside
nl80211_crypto_settings be added to ibss_params or mesh_config/mesh_setup?
I don't think it matters - they just don't support this now and don't
really need to.
Except that the eapol over nl80211 flag is being sent in security
settings. This covers STA/AP/P2P_GO/P2P_CLIENT. We need some way of
passing this information for mesh & ibss.
Regards,
-Denis
