On Sat, 2018-01-27 at 13:22 -0600, Larry Finger wrote: > On 01/26/2018 01:46 AM, pkshih@xxxxxxxxxxx wrote: > > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > > Tell wifi and BT firmware the default port ID to set multiports' state > > properly, but only 8822be needs this function currently. > > > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > --- > > This patch results in the following compiler warnings: > > CC [M] drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.o > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1052:13: warning: > ‘halbtc_set_default_port_id_cmd’ defined but not used [-Wunused-function] > static void halbtc_set_default_port_id_cmd(void *bt_context) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1042:13: warning: > ‘halbtc_send_wifi_port_id_cmd’ defined but not used [-Wunused-function] > static void halbtc_send_wifi_port_id_cmd(void *bt_context) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Something seems to be wrong. As these routines will likely be needed later, you > need to remove the static notation and put their prototypes in a header to quiet > Sparse. Yes, later commit needs them. I'll fix these warnings in v2. PK
