On Mon, 2017-12-11 at 14:02 +0100, Benjamin Beichler wrote: > > > But you added this: > > > > + /* list changed */ > > + if (cb->prev_seq && cb->seq != cb->prev_seq) > > + goto cleanup; > > > > which is mostly just a copy of the inline. > > > > johannes > > Year you are right, but for nl_dump_check_consistent() I also need a > header struct to write the flag to it and I thought a ghost header only > to this function is also misleading. But if you think this is better, I > can do that. Or we introduce a function, which really only check > consistency and not also set the flag. I also thought the line is > readable at it's own, because it's simply inconsistent if the sequence > numbers are not equal. It's readable, but there should be an indication to userspace in this case, no? johannes
