Am 11.12.2017 um 13:49 schrieb Johannes Berg: > On Mon, 2017-12-11 at 13:37 +0100, Benjamin Beichler wrote: >> Am 11.12.2017 um 13:14 schrieb Johannes Berg: >>> On Tue, 2017-11-21 at 13:17 +0100, Benjamin Beichler wrote: >>>> Make the dump operation aware of changes on radio list and corresponding >>>> inconsistent dumps. Change the dump iteration to be independent from >>>> increasing radio indices on radio list. >>> Looks like this should use nl_dump_check_consistent()? >>> >>> johannes >>> >> It is called in mac80211_hwsim_get_radio, I didn't changed that. > But you added this: > > + /* list changed */ > + if (cb->prev_seq && cb->seq != cb->prev_seq) > + goto cleanup; > > which is mostly just a copy of the inline. > > johannes Year you are right, but for nl_dump_check_consistent() I also need a header struct to write the flag to it and I thought a ghost header only to this function is also misleading. But if you think this is better, I can do that. Or we introduce a function, which really only check consistency and not also set the flag. I also thought the line is readable at it's own, because it's simply inconsistent if the sequence numbers are not equal. -- M.Sc. Benjamin Beichler Universität Rostock, Fakultät für Informatik und Elektrotechnik Institut für Angewandte Mikroelektronik und Datentechnik University of Rostock, Department of CS and EE Institute of Applied Microelectronics and CE Richard-Wagner-Straße 31 18119 Rostock Deutschland/Germany phone: +49 (0) 381 498 - 7278 email: Benjamin.Beichler@xxxxxxxxxxxxxx www: http://www.imd.uni-rostock.de/
