Arend, Did this bug ever get fixed, or are 4330's still ending up advertising BCRM_TEST_SSID when they're put into AP mode with mainline kernels? It would be good to know whether I can drop my patch for this from my kernel tree and still have working AP mode. Thanks. On Mon, Jul 31, 2017 at 10:28:50PM +0200, Arend van Spriel wrote: > On 31-07-17 14:59, Russell King - ARM Linux wrote: > > On Fri, Jul 28, 2017 at 09:50:21PM +0200, Arend van Spriel wrote: > >> I was going to agree with you, but having second thoughts. There are > >> actually two use-cases that need to be handled properly. The regular AP > >> case and the MBSS case. In case of MBSS the initial AP interface will > >> have mbss set to false and subsequent AP interfaces will have mbss set > >> to true, but in firmware this has to be configured inverted. That is > >> what the code above is doing. However, this indeed breaks the regular AP > >> case for firmwares that abuse that setting for testing purposes (no idea > >> why that is in a released firmware). > > > > Maybe detect the BCRM_TEST_SSID string in the firmware file (as it's > > broken up amongst other data, it's not trivial) and disable mbss for > > such firmware? Alternatively, maybe blacklist mbss for some firmware > > versions? > > Well. It seem 43362 chip also had this and we disabled mbss for that > chipset. So we may do that for 4330 as well. > > > Do the firmware versions that include this "abuse" actually have > > functional mbss? > > Digging through our internal bug database I found a remark that > BRCM_TEST_SSID showing up means mbss is not functional. > > > There's also the obvious question: which firmware is recommended for > > the 4330? > > We tend to rely on what is released to AOSP as our team does not have > the bandwidth to go through the release process. I checked and it is > still the same so matches what is in linux-firmware. > > Regards, > Arend -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
