Felix Fietkau <nbd@xxxxxxxx> writes: > On 2017-11-10 01:48, Toke Høiland-Jørgensen wrote: >> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the >> mac80211 TXQs for some devices because of a theoretical throughput >> regression. The original regression report[1] was related to fq_codel >> qdisc drop performance, which was fixed in >> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen >> the TXQ-related regression, so it should be safe to re-enable TXQs. > That commit is unrelated to the fq/codel implementations in mac80211, > since mac80211 with txq does not use qdisc. Yup. Which is why it's odd that the initial bug report referred to this; that would indicate that the regression had nothing to do with TXQs in the first place, and we could have merged this ages ago? -Toke
