Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > From: Steven Ting <steventing@xxxxxxxxxxx> > > After this refactoring, the variables wp and rp in TX ring can only be > updated in OP_TX and TX_OK respectively without protection. The other > changes are listed below: > > 1. remove avl_desc from TX ring, because it can be calculated by wp and rp. > Moreover, we update this variable in op_tx (thread context) and TX_OK > (BH context) without protection. > 2. extend calc_fifo_space(rp, wp) to calc_fifo_space(rp, wp, size), and fix > the caller's parameter 'size'. > 3. Get RX remaining counter only if it count down to zero. > 4. remove available_desc check from Tx ISR > > Signed-off-by: Steven Ting <steventing@xxxxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > Cc: Birming Chiu <birming@xxxxxxxxxxx> > Cc: Shaofu <shaofu@xxxxxxxxxxx> Dropping the rest of the series based on my comments. 4 patches set to Changes Requested. 10036501 [08/11] rtlwifi: rtl_pci: Refactor TX/RX flow 10036503 [09/11] rtlwifi: rtl_pci: 8822BE puts broadcast and multicast packet to HIQ 10036507 [10/11] rtlwifi: Add beacon check mechanism to check if AP settings changed. 10036505 [11/11] rtlwifi: rtl_pci: Fix the bug when inactiveps is enabled. -- https://patchwork.kernel.org/patch/10036501/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
