Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > From: Steven Ting <steventing@xxxxxxxxxxx> > > After this refactoring, the variables wp and rp in TX ring can only be > updated in OP_TX and TX_OK respectively without protection. Why? Try to always answer that, that's the most important part of the commit log. Are you fixing a bug (if yes, describe it briefly), is this just code cleanup or what's your motivation to change the code? > The other changes are listed below: > > 1. remove avl_desc from TX ring, because it can be calculated by wp and rp. > Moreover, we update this variable in op_tx (thread context) and TX_OK > (BH context) without protection. > 2. extend calc_fifo_space(rp, wp) to calc_fifo_space(rp, wp, size), and fix > the caller's parameter 'size'. > 3. Get RX remaining counter only if it count down to zero. > 4. remove available_desc check from Tx ISR One logical change per patch, please. One good rule of thumb is that if you have to list the changes made in patch you need to split the patch. -- Kalle Valo
