On Fri, 2017-10-06 at 12:17 +0200, Toke Høiland-Jørgensen wrote: > > Do you have any opinion on whether to use ERR_PTR or change the > function to an int return and pass the pointer as an argument? At > least ath10k seems to do the latter (returning -ENOENT when no packet > is available). I think using an ERR_PTR is nicer, but I have no strong opinions (I just don't like out parameters all that much and avoid them when possible) johannes
