On Tue, Sep 26, 2017 at 12:18:14PM +0200, Johannes Berg wrote: > On Tue, 2017-09-26 at 11:59 +0200, Stanislaw Gruszka wrote: > > STA_SLOW_THRESHOLD is used only in one function, so don't need to be > > global define. > > > > Patch also fixes problem of htmldocs build I encountered: > > > > Error(.//net/mac80211/sta_info.h:416): cannot understand prototype: > > 'STA_SLOW_THRESHOLD 6000????' > > Why not just change /** to /*? I think it's better to keep it there > even if it's not used, it's a more public thing than the code? I thought local references are preferred over global. Fixing only comment is fine for me, I'll post v2. Stanislaw
