On Sun, 22 Jun 2008, Fabien Crespel wrote:
> I've been testing this series of patch today for a new version of
> asus-laptop, and this patch ("rfkill: do not allow userspace to override
> ALL RADIOS OFF") introduces a bug in rfkill-input.
More than one, apparently. Dmitry pointed out that _epo needs to be called
in task context, which rfkill-input was failing to do.
> rfkill_epo() doesn't change the current_state of the tasks, and the
> various calls to rfkill_schedule_set(..., RFKILL_STATE_ON) don't work if
> the last current_state stored was already RFKILL_STATE_ON.
>
> Anyway, the whole current_state thing seems completely useless and a
> source of problems in rfkill-input, since state comparison is already
> done in rfkill, and rfkill-input is more than likely to become out of
> sync with the real state.
>
> Therefore I propose this additional patch to remove current_state
> completely from rfkill-input.
I would like to get rid of it, but I need some sleep before I can think
clearly about this issue.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
