Am 08.09.2017 um 16:26 schrieb Johannes Berg: > On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote: >> For correct interpretation of a tx rate, the corresponding rate flags >> are needed (e.g. whether a HT-MCS rate or a legacy rate) and >> moreover for more correct simulation the other infos of the flags are >> important (like short-GI). Keeping compability, the flags >> are not integrated into the existing hwsim_tx_rate, but transmitted >> as an additional netlink attribute. > This still exposes a lot of internal detail - perhaps it'd be better to > convert to some sort of stable rate representation, like in cfg80211? > Not sure that's sufficient though, it's a bit less detailed. I don't know what is the problem with the details. The only flag, which is a bit to verbose is MAC80211_HWSIM_TX_RC_DUP_DATA, which we may omit. All others describe directly terms used in the IEEE 802.11 standard. Also the representation, that a rate is an MCS-index is quite good. If you take look here http://mcsindex.com/ , the bitrate would be not sufficient to get the exact coding and fec rate, therefore you would also need additional flags. You are right regarding legacy rates, which are in an encoded table. I tried to decouple internal and external API, but currently there is no big difference. Nonetheless the whole hwsim API is highly specialized and only usable with the linux kernel. Of course the Userland API should be more or less stable, but the backward compatibility is not touched by this change. As I already said, this is nearly a fix for hwsim, since currently it's impossible to differentiate between legacy and MCS-rates, although they could appear in a single tx_rates array. I think currently minstrel does not mix HT and legacy rates for data frames, but AFAIK Management/Action frames are always sent with legacy rates, so there are mixed already. > johannes kind regards Benjamin -- M.Sc. Benjamin Beichler Universität Rostock, Fakultät für Informatik und Elektrotechnik Institut für Angewandte Mikroelektronik und Datentechnik University of Rostock, Department of CS and EE Institute of Applied Microelectronics and CE Richard-Wagner-Straße 31 18119 Rostock Deutschland/Germany phone: +49 (0) 381 498 - 7278 email: Benjamin.Beichler@xxxxxxxxxxxxxx www: http://www.imd.uni-rostock.de/
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
