On 23/08/17 13:36, Julian Calaby wrote: > Hi Ian, > > On Wed, Aug 23, 2017 at 10:27 PM, Ian Molton <ian@xxxxxxxxxxxxxx> wrote: >> On 23/08/17 11:09, Julian Calaby wrote: >>> I don't think I explained my point well. >>> >>> The description of this patch implies that this method >>> brcmf_sdiod_ramrw(), now relies on the window being set elsewhere >>> before it's called. >> >> I don't think it does. > > "Resetting" can mean both changing it back after setting it to > something or changing it from some other state to a known one. I read > it as the latter. True >>> I'm asking why we can't move the setting of the window inside this >>> function and remove any redundant calls to >>> brcmf_sdiod_set_backplane_window() outside of it. >> >> We do call brcmf_sdiod_set_backplane_window() in this function. We just >> dont need to call it a second time to restore the original window. > > Ah, I do not have the full code in front of me, so I couldn't see > that, therefore my point is invalid. No worries. -Ian
