Hi Ian,
On Tue, Aug 22, 2017 at 9:25 PM, Ian Molton <ian@xxxxxxxxxxxxxx> wrote:
> All functions that might require the window address changing call
> brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
> the window is not required.
Wouldn't it be more safe to write these sorts of functions so that
they set the window themselves instead of relying on the caller?
> Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> index 0d37c68637f2..cabfab9a02a2 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -721,11 +721,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool write, u32 address,
>
> dev_kfree_skb(pkt);
>
> - /* Return the window to backplane enumeration space for core access */
> - if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
> - brcmf_err("FAILED to set window back to 0x%x\n",
> - sdiodev->sbwad);
> -
> sdio_release_host(sdiodev->func[1]);
>
> return err;
> --
> 2.11.0
>
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
