Re: [4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1

Hans de Goede <hdegoede@xxxxxxxxxx> · Mon, 14 Aug 2017 19:25:35 +0200

Hi,

On 14-08-17 17:46, Kalle Valo wrote:
Hans de Goede <hdegoede@xxxxxxxxxx> writes:

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index d21258d..def120c 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -159,8 +159,9 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)

          brcmf_feat_firmware_capabilities(ifp);
          memset(&gscan_cfg, 0, sizeof(gscan_cfg));
-       brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg",
-                                 &gscan_cfg, sizeof(gscan_cfg));
+       if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID)
+               brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN,
"pfn_gscan_cfg",
+                                         &gscan_cfg, sizeof(gscan_cfg));
          brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn");
          if (drvr->bus_if->wowl_supported)
                  brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl");


AFAICT this is still a problem with 4.13-rc5, can we at least get
the above workaround merged for 4.13 ?

Just applied it few hours ago:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=e9bf53ab1ee34bb05c104bbfd2b77c844773f8e6

I'll try to get it to -rc6 but of course it depends on pull schedules if
it makes it or not.

Ok, thank you.

Regards,

Hans






