On 22-07-17 21:19, Ian Molton wrote: > On 22/07/17 20:18, Ian Molton wrote: >> On 22/07/17 19:43, Hans de Goede wrote: >>> Hi, >>> >>> When upgrading my devel environment to 4.13-rc1+ I noticed that >>> the brcm43430 sdio wifi on a Chuwi Hi8 plus stopped working: >> >> There is a fix for this: >> >> https://patchwork.kernel.org/patch/9836383/ > > Sorry, ignore me - this was a fix for the other 4.13-rc1 regression. > Arend is looking into he other one. It affects me too. > > It appears to be the firmware going astray. It is still an enigma although admittedly I did not put much time in it this week. The change below fixes it as the device goes haywire from this command. At least this was reported by Stefan Wahren ("brcmfmac: BCM43431 won't get probed on Raspberry Pi Zero W") on linux-wireless mailing list. Still I can not explain it. Could be that there is not enough free memory on the device. Regards, Arend --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c index d21258d..def120c 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c @@ -159,8 +159,9 @@ void brcmf_feat_attach(struct brcmf_pub *drvr) brcmf_feat_firmware_capabilities(ifp); memset(&gscan_cfg, 0, sizeof(gscan_cfg)); - brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg", - &gscan_cfg, sizeof(gscan_cfg)); + if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID) + brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg", + &gscan_cfg, sizeof(gscan_cfg)); brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn"); if (drvr->bus_if->wowl_supported) brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl");
