> Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> writes: > > > This patch implements AP_VLAN interface type support enabling > > the use of dynamic VLAN mode in hostapd. > > > > Implementation notes. [...] > > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> > > This looks somewhat controversial to me but I'm not very familiar with > VLANs. Do other wireless drivers do something similar or how is this > usually implemented? Or not at all? > > -- > Kalle Valo Well, IIUC this feature is not supported by other full-mac drivers at the moment, so no good example to follow. I don't think it is too controversial. Probably the restrictions on hostapd AP_VLAN interface names can be frowned upon. But at the moment this information is not passed by hostapd to kernel. It needs some additional work both in hostapd and cfg80211 to get this info directly in the driver. Anyways, other patches in this series are more straighforward. So I will split submission in v2: AP_VLAN support will be posted separately as RFC in order to some feedback regarding the overall approach. Regards, Sergey
