On Tue, Jun 27, 2017 at 7:56 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes: > >> We have internal management frames(commands) sent to firmware for >> various configurations. This patch defines some common structures >> which can be shared by those frames. Key handling and regulatory >> enhancements are also includesd. With this patch series included, >> station can connect to security enabled AP and send/receive data. > > Are you saying that before rsi driver was not able to connect a security > enabled AP? Just trying to understand the status. Right. It wasn't able to connect security enabled AP. The key handling enhancements in this patch series made it work. > >> Prameela Rani Garnepudi (17): >> rsi: add common structures needed for command packets >> rsi: immediate wakeup bit and priority for TX command packets >> rsi: Update in tx command frame radio capabilities >> rsi: remove unnecessary check for 802.11 management packet >> rsi: Update peer notify command frame >> rsi: Update aggregation parameters command frame >> rsi: Update baseband RF programming frame >> rsi: update set_channel command frame >> rsi: update vap capabilities command frame >> rsi: update set_key command frame >> rsi: set_key enhancements >> rsi: update autorate request command frame >> rsi: block/unblock data queues as per connection status >> rsi: update tx command frame block/unblock data >> rsi: Remove internal header from Tx status skb >> rsi: Send rx filter frame to device when interface is down >> rsi: regulatory enhancements > > Also in the future please try to keep the size of patchsets in > reasonable sizes. Something like max 10-12 patches per set is usually > ok, dependinging on the size of patches of course. But anything more > than that and the review becomes too annoying. Sure. I will keep this in mind. Regards, Amitkumar Karwar