Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > The ap_num can be filled by wpa_cli's VENDOR command. > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > Cc: Birming Chiu <birming@xxxxxxxxxxx> > Cc: Shaofu <shaofu@xxxxxxxxxxx> > Cc: Steven Ting <steventing@xxxxxxxxxxx> This is a perfect example why I have been against vendor commands in the past. I already regret changing my mind... If you want me to seriously consider taking a patch adding a vendor command I need GOOD justifications why a normal nl80211 command is not suitable and which are properly documented in the commit log. One sentence definitely is not enough. Larry, please drop all patches related to vendor commands in this patch and resend. Adding vendor commands should be in a separate patchset so it can be discussed without blocking anything else. -- https://patchwork.kernel.org/patch/9798295/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
