Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:
> From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> To yield better user experience, have btcoex control LPS's parameters.
>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
> Cc: Birming Chiu <birming@xxxxxxxxxxx>
> Cc: Shaofu <shaofu@xxxxxxxxxxx>
> Cc: Steven Ting <steventing@xxxxxxxxxxx>
[...]
> - u8 rlbm, power_state = 0, byte5 = 0x40;
> + u8 rlbm, power_state = 0, byte5 = 0;
[...]
> + if ((rlbm == 2) && (byte5 & BIT(4))) {
> + /* Keep awake interval to 1 to prevent from
> + * decreasing coex performance
> + */
> + awake_intvl = 2;
> + rlbm = 2;
> + }
These kind of magic values (byte5 & BIT(4)) don't really belong in
upstream drivers and I'm seeing way too much of those in rtlwifi.
I'm not going to drop this patch because of this but please make an
effort to do packet parsing properly, for example with help of structs
and defines/enums.
--
Kalle Valo
