On Fri, Jun 13, 2008 at 3:16 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> > If you managed to get along without this for so long, why is it needed >> > in upstream now? >> >> We didn't run without it, We were developing HW 5000 on older kernel >> now I just merging it upstream. See my announcement Try to imagine >> that there is world on totally different planet with different >> gravitation constant, > > Heh. But that still doesn't explain why you're pushing this API into the > upstream kernel. Because the testing automation didn't change a.k.a user space. >> >> > Remember, sysfs is API. You don't get to change it gratuitously, so >> > neither should you add to it gratuitously. And we already _have_ API for >> > this particular thing which is not dependent on a particular >> > hardware/driver to boot! >> Agree. We've just returned what was there before >> I think you understand what legacy means after your try to replace >> wext. It will take time >> till we switch to new API. Unfortunately cannot fix everything in one day. > > I know, and that's why wext will stay around for a long time to come. > I'm well aware of that, and I think you're aware of that as well. I just > don't see the point of _adding_ to the problem with gratuitous API It's not __adding__ it's __restoring__ even the entry it self was never removed. > proliferation when apparently you can very well manage to live without > this piece. I 've just tried to explain to you that I cannot live without it...probably without much success > Couldn't you move it all to debugfs, which is understood to not really > be API, and change your verification scripts to use /sys/debug instead > of /sys? There is so much junk in current iwlwifi sysfs that remains there form the time 0 where debugfs was not around so I'm not sure what's your point here. Cleaning it is currently not my highest priority, let first make driver works properly then we can clean it up. Will it make you happy if we schedule to remove it before 2.6.27 merging window. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html