> >> drivers/net/wireless/iwlwifi/iwl4965-base.c | 58 ++++++++++++++++++++++++++-
> >> 1 files changed, 56 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c b/drivers/net/wireless/iwlwifi/iwl4965-base.c
> >> index 81a1c22..c179b21 100644
> >> --- a/drivers/net/wireless/iwlwifi/iwl4965-base.c
> >> +++ b/drivers/net/wireless/iwlwifi/iwl4965-base.c
> >> @@ -4122,8 +4122,62 @@ static DEVICE_ATTR(power_level, S_IWUSR | S_IRUSR, show_power_level,
> >> static ssize_t show_channels(struct device *d,
> >> struct device_attribute *attr, char *buf)
> >> {
> >> - /* all this shit doesn't belong into sysfs anyway */
> >> - return 0;
> >
> > Hehe. Do you really have to? You can query this information with
> > nl80211. I don't know why you need all that sysfs stuff anyway.
>
> I'm not sure why Yi has cut off the log message but original was
>
> 'This patch returns channel list to sysfs. This is requirement
> for validation purposes'
>
> Our automation is build around sysfs and wext and I'm not going to
> rewrite it now.
If you managed to get along without this for so long, why is it needed
in upstream now?
Remember, sysfs is API. You don't get to change it gratuitously, so
neither should you add to it gratuitously. And we already _have_ API for
this particular thing which is not dependent on a particular
hardware/driver to boot!
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
