On Fri, 2017-04-07 at 21:06 +0200, Pablo Neira Ayuso wrote: > On Fri, Apr 07, 2017 at 08:59:12PM +0200, Johannes Berg wrote: > [...] > > Heh. I think I really want to solve - at least partially - > > nla_parse() > > to see that it can be done this way. It'd be nice to even transform > > all > > the callers (I generated half of these patches with spatch anyway) > > to > > have at least that. > > We can just have a modified version of nla_parse that deals with > this. Yes, but we need to figure out a good way to have the offset. We also need to see if we want to *force* having the offset. In some sense that'd be useful, in another it might be very complicated to fill it in at all times, if for example errors come from lower layers like drivers. (It's ultimately always going to be optional since we'll continue returning errors without *any* extended error information - likely indefinitely - but if we have a wrong attribute, should we always have an offset? Would be nice, but could be difficult in practice) > We can probably use struct nla_policy to place the extended error > code or the string (as we discussed I don't need string errors, but > I'm fine if other people find it useful). I don't think for the error strings really would be useful for nla_parse() or a policy - we can return something generic like "malformed attribute" there as a string, and hopefully point to the attribute/offset from there generically. I just really want to see how to actually do that. johannes
