On Thu, 2008-06-12 at 12:56 +0300, Rindjunsky, Ron wrote: > >> - /* > >> - * Warn when submitting a fragmented A-MPDU frame and drop it. > >> - * This is an error and needs to be fixed elsewhere, but when > >> - * done needs to take care of monitor interfaces (injection) > >> - * etc. > >> - */ > >> - if (WARN_ON(tx->flags & IEEE80211_TX_CTL_AMPDU || > >> - skb_get_queue_mapping(tx->skb) >= > >> - ieee80211_num_regular_queues(&tx->local->hw))) > >> - return TX_DROP; > >> - > > > Should we keep that, just in case? If it ever happens and the hw > rejects > > a fragment for some reason, we'll otherwise clobber some state and > > probably crash. > > Agree. Should I resend the patch or would you just remove it from the > original patch? Well, you probably want to adjust the comment, since you did fix it elsewhere :) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
